Tests: add dedicated test for the SyntaxError::getLine() method
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grogy
approved these changes
Apr 8, 2022
|
Can you please rebase this PR? After I can merge it :-) |
This safeguards and documents the current behaviour of the method. Includes removing redundant conditional in the original method.
jrfnl
force-pushed
the
feature/new-test-syntax-error-getline
branch
from
c9fdc8b to
0b202ec
Compare
|
Rebased without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This safeguards and documents the current behaviour of the method.
Includes removing redundant conditional in the original method.