GH Actions: fix duplicate release #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/ghactions-fix-release-being-created-twice
branch
from
c312a8b to
271b8b1
Compare
As things were, the workflow was creating two releases, one in draft and one published, but without a good name/changelog. I noticed this last time there was a release, but never got round to fixing it (and it wasn't urgent as no new release was needed). As a new release is needed soon, now seemed like a good time to fix this. The `actions/create-release` action runner has been abandoned and mentions the `softprops/action-gh-release` action runner as a replacement. This commit now updates the workflow to solely use the `softprops/action-gh-release` action runner and updates the version and configuration to make sure it only creates a draft release, so we can still edit it and add the changelog before publishing.
jrfnl
force-pushed
the
feature/ghactions-fix-release-being-created-twice
branch
from
271b8b1 to
3e22507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As things were, the workflow was creating two releases, one in draft and one published, but without a good name/changelog. I noticed this last time there was a release, but never got round to fixing it (and it wasn't urgent as no new release was needed).
As a new release is needed soon, now seemed like a good time to fix this.
The
actions/create-releaseaction runner has been abandoned and mentions thesoftprops/action-gh-releaseaction runner as a replacement.This commit now updates the workflow to solely use the
softprops/action-gh-releaseaction runner and updates the version and configuration to make sure it only creates a draft release, so we can still edit it and add the changelog before publishing.