Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide one true way to run the test suite #37

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Provide one true way to run the test suite #37

merged 1 commit into from
Aug 20, 2020

Conversation

mfn
Copy link

@mfn mfn commented Jul 4, 2020

I checked out the project and it wasn't clear to me how to run the tests (as its not using phpunit). After searching around I found two variations of how to run the tests.

Adding a scripts entry to composer provides a single definition on how to run the tests, usable for every one; also locally:

$ composer tests
> tester -p php tests
 _____ ___  ___ _____ ___  ___
|_   _/ __)( __/_   _/ __)| _ )
  |_| \___ /___) |_| \___ |_|_\  v2.3.2

Note: No php.ini is used.
PHP 7.4.7 (cli) | php -n | 8 threads

.........................


OK (25 tests, 1.4 seconds)

After that I adapted the existing ones to use the one from composer.

Thanks!

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@mfn
Copy link
Author

mfn commented Jul 19, 2020

Feedback applied!

@grogy grogy merged commit 5263bbb into php-parallel-lint:master Aug 20, 2020
@grogy
Copy link
Member

grogy commented Aug 20, 2020

Thank you and thanks @jrfnl and @villfa for comments.

@mfn mfn deleted the mfn-tests branch August 20, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants