Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unsealed shapes in conditional return types #251

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

IanDelMar
Copy link
Contributor

@IanDelMar IanDelMar commented Oct 10, 2024

Closes #248

@kkmuffme
Copy link

That's perfect how it should be in an ideal world :-) Unfortunately, some tools (afair phpstorm for example), still don't support the "..." syntax, but do support the &array syntax.

If you could just Search/Replace All ,... } with }&array ?

@IanDelMar
Copy link
Contributor Author

I opted for the ,... } to avoid stating that the intersection of {A, B, C} and {C, D, E} is anything other than C. 😞 But will change to }&array...

@IanDelMar
Copy link
Contributor Author

@szepeviktor This PR is complete.

@szepeviktor
Copy link
Member

Unfortunately, some tools (afair phpstorm for example),

Viktor is also afraid.

@szepeviktor szepeviktor merged commit 113b3f7 into php-stubs:master Oct 10, 2024
5 checks passed
@IanDelMar IanDelMar deleted the sealed-unsealed branch October 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wp_die return type is wrong
3 participants