Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for php 8.2: declare used properties #24

Closed
wants to merge 1 commit into from
Closed

Conversation

remicollet
Copy link
Member

No description provided.

@andypost
Copy link
Contributor

It needs rebase but it fixes all failed tests, before patch

FAILED TEST SUMMARY
---------------------------------------------------------------------
OauthProvider Creation [tests/oauthprovider_001.phpt]
OauthProvider isRequestTokenEndpoint [tests/oauthprovider_002.phpt]
OauthProvider consumerHandler/callConsumerHandler [tests/oauthprovider_003.phpt]
OauthProvider tokenHandler/callTokenHandler [tests/oauthprovider_004.phpt]
OauthProvider timestampNonceHandler/callTimestampNonceHandler [tests/oauthprovider_005.phpt]
OauthProvider checkOauthRequest [tests/oauthprovider_006.phpt]
OauthProvider checkOauthRequest [tests/oauthprovider_007.phpt]
OauthProvider setParam addref segfault [tests/oauthprovider_008.phpt]

meantime while building there's warning

/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/oauth.c: In function 'make_req_streams':
/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/oauth.c:918:61: warning: the comparison will always evaluate as 'true' for the address of 'last_location_header' will never be NULL [-Waddress]
  918 |                         if (HTTP_IS_REDIRECT(response_code) && soo->last_location_header) {
      |                                                             ^~
In file included from /mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/oauth.c:12:
/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/php_oauth.h:221:14: note: 'last_location_header' declared here
  221 |         char last_location_header[OAUTH_MAX_HEADER_LEN];
      |              ^~~~~~~~~~~~~~~~~~~~
/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/oauth.c: In function 'make_req_curl':
/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/oauth.c:1234:61: warning: the comparison will always evaluate as 'true' for the address of 'last_location_header' will never be NULL [-Waddress]
 1234 |                         if (HTTP_IS_REDIRECT(response_code) && soo->last_location_header) {
      |                                                             ^~
/mnt/testing/php82-pecl-oauth/src/pecl-web_services-oauth-2.0.8/php_oauth.h:221:14: note: 'last_location_header' declared here
  221 |         char last_location_header[OAUTH_MAX_HEADER_LEN];
      |              ^~~~~~~~~~~~~~~~~~~~

@remicollet remicollet closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants