Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MT_RAND_PHP #11560

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Deprecate MT_RAND_PHP #11560

merged 4 commits into from
Jul 7, 2023

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla added the RFC label Jun 29, 2023
@TimWolla TimWolla marked this pull request as ready for review July 6, 2023 13:40
@TimWolla TimWolla requested a review from zeriyoshi as a code owner July 6, 2023 13:40
@TimWolla TimWolla requested review from kocsismate and Girgias July 6, 2023 13:40
Girgias
Girgias approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like at one point it might make sense to deprecate the mode parameter all together.

@TimWolla
Copy link
Member Author

TimWolla commented Jul 6, 2023

Seems like at one point it might make sense to deprecate the mode parameter all together.

Yes, it should probably be deprecated once there is only one legal value left (i.e. as part of the removal of MT_RAND_PHP). At that point Mt19937 with MT_RAND_PHP will also fail to unserialize.

zeriyoshi
zeriyoshi approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@zeriyoshi zeriyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@TimWolla TimWolla merged commit 6125109 into php:master Jul 7, 2023
@TimWolla TimWolla deleted the deprecate-mt-rand-php branch July 7, 2023 10:16
@jrfnl jrfnl mentioned this pull request Aug 10, 2023
Merged
This was referenced Sep 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeriyoshi zeriyoshi zeriyoshi approved these changes

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Extension: random RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimWolla @kocsismate @Girgias @zeriyoshi