Fix GH-8928 memory leak with long query/CLOB #8946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_oci8_mem_leak
branch
from
3fd4d8a
to
7213a0e
Compare
mvorisek
force-pushed
the
fix_oci8_mem_leak
branch
from
1343564
to
afe5a38
Compare
mvorisek
force-pushed
the
fix_oci8_mem_leak
branch
from
afe5a38
to
5f207e6
Compare
|
I have rebased this repro leak code on the latest PHP 8.0 branch /w Oracle CI. Can someone please look into it? CI output: https://github.com/php/php-src/runs/8018590879?check_suite_focus=true#step:9:105 |
mvorisek
force-pushed
the
fix_oci8_mem_leak
branch
from
5f207e6
to
1310df6
Compare
|
This PR does not do what it describes, removes lots of things from tests and has conflicts. It's also targeting the wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix php/pecl-database-oci8#4