Skip to content

Commit

Permalink
Add baseline for indirect deprecations
Browse files Browse the repository at this point in the history
We cannot fix these PHP deprecations, as these are happening in third
party code (and fixing them requires a major version bump of Flysystem).

PHPUnit 11 distinguishes direct and indirect deprecations, allowing us
to automatically ignore all indirect deprecations. However, this version
requires PHP 8.2, while this library still supports PHP 8.1.
  • Loading branch information
wouterj committed Dec 1, 2024
1 parent 4b83571 commit a1cc381
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
13 changes: 13 additions & 0 deletions phpunit-baseline.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0"?>
<files version="1">
<file path="vendor/league/flysystem/src/FilesystemInterface.php">
<line number="274" hash="974a66e314c847f29d4b178ad6b47395be68d98f">
<issue><![CDATA[League\Flysystem\FilesystemInterface::get(): Implicitly marking parameter $handler as nullable is deprecated, the explicit nullable type must be used instead]]></issue>
</line>
</file>
<file path="vendor/league/flysystem/src/Filesystem.php">
<line number="363" hash="813ac25441e5e8e2323613ee4eee44ff5927e423">
<issue><![CDATA[League\Flysystem\Filesystem::get(): Implicitly marking parameter $handler as nullable is deprecated, the explicit nullable type must be used instead]]></issue>
</line>
</file>
</files>
2 changes: 1 addition & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</testsuite>
</testsuites>
<coverage/>
<source ignoreSuppressionOfDeprecations="true">
<source ignoreSuppressionOfDeprecations="true" baseline="phpunit-baseline.xml">
<include>
<directory suffix=".php">packages/**/src</directory>
</include>
Expand Down

0 comments on commit a1cc381

Please sign in to comment.