Added support for mixin #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
commented
Jan 6, 2021
| $fqn = $class->scope()->resolveLocalName($name); | ||
| $mixinClass = $locator->reflector()->reflectClass($fqn); | ||
|
|
||
| $collection = $collection->merge($mixinClass->members()); |
There was a problem hiding this comment.
note this is wrong. this will add the actual members to the class and make no distinction between the "real" methods and the fake ones.
we will need to convert the actual member to a VirtualMember.
There was a problem hiding this comment.
also handle class-not-found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.