New failures since upgrade to PHP 8

[drupol]

Hi,

I upgraded to PHP8 and I'm having issues with some tests now. Those issue were not existing in PHP 7.4.19.

See more context here: loophp/collection#103

I think it's definitely an issue with PHPSpec.
Look, I'm currently working for work and I'm having the same kind of issue, see:

The test can be found here: https://github.com/ecphp/cas-bundle/blob/master/spec/EcPhp/CasBundle/Security/Core/User/CasUserProviderSpec.php#L72

[kelunik]

The issue is

phpspec/src/PhpSpec/Runner/Maintainer/ErrorMaintainer.php

Line 95 in eb0d939

if (0 !== error_reporting()) {

not checking properly for error suppression. It needs to use a bit mask as documented on PHP.net, as PHP 8 does no longer suppress fatal errors with @.

[kelunik]

See https://www.php.net/manual/en/function.set-error-handler

[drupol]

I'll submit a PR in 1 or 2 hours. We need this for work.