Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Compatibility #104

Merged
merged 11 commits into from
Jun 6, 2021
Merged

PHP 8 Compatibility #104

merged 11 commits into from
Jun 6, 2021

Conversation

AlexandruGG
Copy link
Collaborator

@AlexandruGG AlexandruGG commented Jun 1, 2021 •
edited
Loading

This PR ensures this library is always checked for full PHP 8 compatibility, based on the discussion #103

  • updating CI workflows to run on PHP 8 as well as PHP 7.4
  • fixing a couple static analysis issues
  • handle usage of asyncMap in PHP in the CollectionSpec. Due to an issue New failures since upgrade to PHP 8 phpspec/phpspec#1375 with PHPSpec the test fails. Should be fixed soon however
  • requiring the PHP 8 jobs to merge in the settings.yml

@AlexandruGG AlexandruGG changed the title Feature/php8 compatiblity PHP 8 [Soft] Compatibility Jun 1, 2021
@AlexandruGG AlexandruGG marked this pull request as ready for review June 1, 2021 16:06
drupol
drupol requested changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexandruGG,

Very nice work, thanks!

I gave my feedback, let me know what you think.

composer.json Outdated Show resolved Hide resolved
src/Collection.php Show resolved Hide resolved
@AlexandruGG
Copy link
Collaborator Author

Don't merge this yet as I want to see what comes out of the discussion on asyncMap #103. It looks like the library is working in PHP 8, it's just PHPSpec that's failing

@AlexandruGG AlexandruGG changed the title PHP 8 [Soft] Compatibility PHP 8 Compatibility Jun 6, 2021
@AlexandruGG
Copy link
Collaborator Author

@drupol hey, I think we should merge this because it adds the PHP 8 CI jobs and so will ensure any future code changes will be compatible with PHP 8.

It might take a bit to get the phpspec issue merged and released, but at that point we can just update this test.

@drupol drupol merged commit 0b95b8a into loophp:master Jun 6, 2021
@AlexandruGG AlexandruGG deleted the feature/php8-compatiblity branch June 6, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandruGG @drupol