Allow nonexistent other-than-Variable expressions in by-ref parameters

phpstan · Sep 10, 2024 · 00d2caf · 00d2caf
1 parent d3a2a92
commit 00d2caf
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -4570,20 +4570,18 @@ private function processArgs(
 
 			$lookForUnset = false;
 			if ($assignByReference) {
-				if ($arg->value instanceof Variable) {
-					$isBuiltin = false;
-					if ($calleeReflection instanceof FunctionReflection && $calleeReflection->isBuiltin()) {
-						$isBuiltin = true;
-					} elseif ($calleeReflection instanceof ExtendedMethodReflection && $calleeReflection->getDeclaringClass()->isBuiltin()) {
-						$isBuiltin = true;
-					}
-					if (
-						$isBuiltin
-						|| ($parameterNativeType === null || !$parameterNativeType->isNull()->no())
-					) {
-						$scope = $this->lookForSetAllowedUndefinedExpressions($scope, $arg->value);
-						$lookForUnset = true;
-					}
+				$isBuiltin = false;
+				if ($calleeReflection instanceof FunctionReflection && $calleeReflection->isBuiltin()) {
+					$isBuiltin = true;
+				} elseif ($calleeReflection instanceof ExtendedMethodReflection && $calleeReflection->getDeclaringClass()->isBuiltin()) {
+					$isBuiltin = true;
+				}
+				if (
+					$isBuiltin
+					|| ($parameterNativeType === null || !$parameterNativeType->isNull()->no())
+				) {
+					$scope = $this->lookForSetAllowedUndefinedExpressions($scope, $arg->value);
+					$lookForUnset = true;
 				}
 			}