Remove __set_state() on objects that should not be serialized in cache

phpstan · Sep 30, 2024 · 38cb5a3 · 38cb5a3
1 parent 1fb2cdd
commit 38cb5a3
Show file tree

Hide file tree

Showing 67 changed files with 1 addition and 600 deletions.
diff --git a/UPGRADING.md b/UPGRADING.md
@@ -280,3 +280,4 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
 * Remove `FunctionReflection::isFinal()`
 * [`Type::getProperty()`](https://apiref.phpstan.org/2.0.x/PHPStan.Type.Type.html#_getProperty) now returns [`ExtendedPropertyReflection`](https://apiref.phpstan.org/2.0.x/PHPStan.Reflection.ExtendedPropertyReflection.html)
 * `additionalConfigFiles` config parameter must be a list
+* Remove `__set_state()` on objects that should not be serialized in cache
diff --git a/src/Analyser/NameScope.php b/src/Analyser/NameScope.php
@@ -222,21 +222,4 @@ public function hasTypeAlias(string $alias): bool
 		return array_key_exists($alias, $this->typeAliasesMap);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): self
-	{
-		return new self(
-			$properties['namespace'],
-			$properties['uses'],
-			$properties['className'],
-			$properties['functionName'],
-			$properties['templateTypeMap'],
-			$properties['typeAliasesMap'],
-			$properties['bypassTypeAliases'],
-			$properties['constUses'],
-		);
-	}
-
 }
diff --git a/src/Reflection/Native/NativeParameterReflection.php b/src/Reflection/Native/NativeParameterReflection.php
@@ -63,19 +63,4 @@ public function union(self $other): self
 		);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): self
-	{
-		return new self(
-			$properties['name'],
-			$properties['optional'],
-			$properties['type'],
-			$properties['passedByReference'],
-			$properties['variadic'],
-			$properties['defaultValue'],
-		);
-	}
-
 }
diff --git a/src/Reflection/Native/NativeParameterWithPhpDocsReflection.php b/src/Reflection/Native/NativeParameterWithPhpDocsReflection.php
@@ -81,24 +81,4 @@ public function getClosureThisType(): ?Type
 		return $this->closureThisType;
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): self
-	{
-		return new self(
-			$properties['name'],
-			$properties['optional'],
-			$properties['type'],
-			$properties['phpDocType'],
-			$properties['nativeType'],
-			$properties['passedByReference'],
-			$properties['variadic'],
-			$properties['defaultValue'],
-			$properties['outType'],
-			$properties['immediatelyInvokedCallable'],
-			$properties['closureThisType'],
-		);
-	}
-
 }
diff --git a/src/Reflection/PassedByReference.php b/src/Reflection/PassedByReference.php
@@ -76,12 +76,4 @@ public function combine(self $other): self
 		return $this;
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): self
-	{
-		return new self($properties['value']);
-	}
-
 }
diff --git a/src/TrinaryLogic.php b/src/TrinaryLogic.php
@@ -251,12 +251,4 @@ public function describe(): string
 		return $labels[$this->value];
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): self
-	{
-		return self::create($properties['value']);
-	}
-
 }
diff --git a/src/Type/Accessory/AccessoryArrayListType.php b/src/Type/Accessory/AccessoryArrayListType.php
@@ -472,11 +472,6 @@ public function traverseSimultaneously(Type $right, callable $cb): Type
 		return $this;
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function exponentiate(Type $exponent): Type
 	{
 		return new ErrorType();

diff --git a/src/Type/Accessory/AccessoryLiteralStringType.php b/src/Type/Accessory/AccessoryLiteralStringType.php
@@ -352,11 +352,6 @@ public function generalize(GeneralizePrecision $precision): Type
 		return new StringType();
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function exponentiate(Type $exponent): Type
 	{
 		return new BenevolentUnionType([

diff --git a/src/Type/Accessory/AccessoryLowercaseStringType.php b/src/Type/Accessory/AccessoryLowercaseStringType.php
@@ -348,11 +348,6 @@ public function generalize(GeneralizePrecision $precision): Type
 		return new StringType();
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function exponentiate(Type $exponent): Type
 	{
 		return new BenevolentUnionType([

diff --git a/src/Type/Accessory/AccessoryNonEmptyStringType.php b/src/Type/Accessory/AccessoryNonEmptyStringType.php
@@ -344,11 +344,6 @@ public function generalize(GeneralizePrecision $precision): Type
 		return new StringType();
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function tryRemove(Type $typeToRemove): ?Type
 	{
 		if ($typeToRemove instanceof ConstantStringType && $typeToRemove->getValue() === '0') {

diff --git a/src/Type/Accessory/AccessoryNonFalsyStringType.php b/src/Type/Accessory/AccessoryNonFalsyStringType.php
@@ -344,11 +344,6 @@ public function generalize(GeneralizePrecision $precision): Type
 		return new StringType();
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function exponentiate(Type $exponent): Type
 	{
 		return new BenevolentUnionType([

diff --git a/src/Type/Accessory/AccessoryNumericStringType.php b/src/Type/Accessory/AccessoryNumericStringType.php
@@ -346,11 +346,6 @@ public function generalize(GeneralizePrecision $precision): Type
 		return new StringType();
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function tryRemove(Type $typeToRemove): ?Type
 	{
 		if ($typeToRemove instanceof ConstantStringType && $typeToRemove->getValue() === '0') {

diff --git a/src/Type/Accessory/HasMethodType.php b/src/Type/Accessory/HasMethodType.php
@@ -200,11 +200,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['methodName']);
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode(''); // no PHPDoc representation

diff --git a/src/Type/Accessory/HasOffsetType.php b/src/Type/Accessory/HasOffsetType.php
@@ -402,11 +402,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['offsetType']);
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode(''); // no PHPDoc representation

diff --git a/src/Type/Accessory/HasOffsetValueType.php b/src/Type/Accessory/HasOffsetValueType.php
@@ -458,11 +458,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['offsetType'], $properties['valueType']);
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode(''); // no PHPDoc representation

diff --git a/src/Type/Accessory/HasPropertyType.php b/src/Type/Accessory/HasPropertyType.php
@@ -162,11 +162,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['propertyName']);
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode(''); // no PHPDoc representation

diff --git a/src/Type/Accessory/NonEmptyArrayType.php b/src/Type/Accessory/NonEmptyArrayType.php
@@ -454,11 +454,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode('non-empty-array');

diff --git a/src/Type/Accessory/OversizedArrayType.php b/src/Type/Accessory/OversizedArrayType.php
@@ -450,11 +450,6 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 	public function toPhpDocNode(): TypeNode
 	{
 		return new IdentifierTypeNode(''); // no PHPDoc representation

diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -562,15 +562,4 @@ public function getFiniteTypes(): array
 		return [];
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self(
-			$properties['keyType'],
-			$properties['itemType'],
-		);
-	}
-
 }
diff --git a/src/Type/BenevolentUnionType.php b/src/Type/BenevolentUnionType.php
@@ -173,12 +173,4 @@ public function traverseSimultaneously(Type $right, callable $cb): Type
 		return $this;
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['types']);
-	}
-
 }
diff --git a/src/Type/BooleanType.php b/src/Type/BooleanType.php
@@ -163,12 +163,4 @@ public function toPhpDocNode(): TypeNode
 		return new IdentifierTypeNode('bool');
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 }
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -680,20 +680,4 @@ public function toPhpDocNode(): TypeNode
 		);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self(
-			(bool) $properties['isCommonCallable'] ? null : $properties['parameters'],
-			(bool) $properties['isCommonCallable'] ? null : $properties['returnType'],
-			$properties['variadic'],
-			$properties['templateTypeMap'],
-			$properties['resolvedTemplateTypeMap'],
-			$properties['templateTags'],
-			$properties['isPure'],
-		);
-	}
-
 }
diff --git a/src/Type/ClassStringType.php b/src/Type/ClassStringType.php
@@ -94,12 +94,4 @@ public function toPhpDocNode(): TypeNode
 		return new IdentifierTypeNode('class-string');
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self();
-	}
-
 }
diff --git a/src/Type/ClosureType.php b/src/Type/ClosureType.php
@@ -799,25 +799,4 @@ public function toPhpDocNode(): TypeNode
 		);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self(
-			$properties['parameters'],
-			$properties['returnType'],
-			$properties['variadic'],
-			$properties['templateTypeMap'],
-			$properties['resolvedTemplateTypeMap'],
-			$properties['callSiteVarianceMap'],
-			$properties['templateTags'],
-			$properties['throwPoints'],
-			$properties['impurePoints'],
-			$properties['invalidateExpressions'],
-			$properties['usedVariables'],
-			$properties['acceptsNamedArguments'],
-		);
-	}
-
 }
diff --git a/src/Type/ConditionalType.php b/src/Type/ConditionalType.php
@@ -188,20 +188,6 @@ public function toPhpDocNode(): TypeNode
 		);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self(
-			$properties['subject'],
-			$properties['target'],
-			$properties['if'],
-			$properties['else'],
-			$properties['negated'],
-		);
-	}
-
 	private function getNormalizedIf(): Type
 	{
 		return $this->normalizedIf ??= TypeTraverser::map(

diff --git a/src/Type/ConditionalTypeForParameter.php b/src/Type/ConditionalTypeForParameter.php
@@ -175,18 +175,4 @@ public function toPhpDocNode(): TypeNode
 		);
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self(
-			$properties['parameterName'],
-			$properties['target'],
-			$properties['if'],
-			$properties['else'],
-			$properties['negated'],
-		);
-	}
-
 }
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -1712,12 +1712,4 @@ public function getFiniteTypes(): array
 		return $finiteTypes;
 	}
 
-	/**
-	 * @param mixed[] $properties
-	 */
-	public static function __set_state(array $properties): Type
-	{
-		return new self($properties['keyTypes'], $properties['valueTypes'], $properties['nextAutoIndexes'] ?? $properties['nextAutoIndex'], $properties['optionalKeys'] ?? [], $properties['isList'] ?? TrinaryLogic::createNo());
-	}
-
 }