Bleeding edge - check instanceof *Type that have better alternative…

… as method on Type
phpstan · Jan 31, 2023 · 436e6d3 · 436e6d3
1 parent e799fc2
commit 436e6d3
Show file tree

Hide file tree

Showing 8 changed files with 866 additions and 0 deletions.
diff --git a/conf/bleedingEdge.neon b/conf/bleedingEdge.neon
@@ -30,3 +30,4 @@ parameters:
 		varTagType: true
 		closureDefaultParameterTypeRule: true
 		newRuleLevelHelper: true
+		instanceofType: true
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -16,6 +16,8 @@ conditionalTags:
 		phpstan.rules.rule: %featureToggles.runtimeReflectionRules%
 	PHPStan\Rules\Api\ApiInstanceofRule:
 		phpstan.rules.rule: %featureToggles.runtimeReflectionRules%
+	PHPStan\Rules\Api\ApiInstanceofTypeRule:
+		phpstan.rules.rule: %featureToggles.instanceofType%
 	PHPStan\Rules\Api\RuntimeReflectionFunctionRule:
 		phpstan.rules.rule: %featureToggles.runtimeReflectionRules%
 	PHPStan\Rules\Api\RuntimeReflectionInstantiationRule:
@@ -92,6 +94,8 @@ services:
 		class: PHPStan\Rules\Api\ApiClassConstFetchRule
 	-
 		class: PHPStan\Rules\Api\ApiInstanceofRule
+	-
+		class: PHPStan\Rules\Api\ApiInstanceofTypeRule
 	-
 		class: PHPStan\Rules\Api\NodeConnectingVisitorAttributesRule
 	-

diff --git a/conf/config.neon b/conf/config.neon
@@ -60,6 +60,7 @@ parameters:
 		varTagType: false
 		closureDefaultParameterTypeRule: false
 		newRuleLevelHelper: false
+		instanceofType: false
 	fileExtensions:
 		- php
 	checkAdvancedIsset: false
@@ -286,6 +287,7 @@ parametersSchema:
 		varTagType: bool()
 		closureDefaultParameterTypeRule: bool()
 		newRuleLevelHelper: bool()
+		instanceofType: bool()
 	])
 	fileExtensions: listOf(string())
 	checkAdvancedIsset: bool()
@@ -443,6 +445,8 @@ conditionalTags:
 		phpstan.parser.richParserNodeVisitor: %featureToggles.nodeConnectingVisitorCompatibility%
 	PHPStan\Parser\CurlSetOptArgVisitor:
 		phpstan.parser.richParserNodeVisitor: %featureToggles.curlSetOptTypes%
+	PHPStan\Parser\TypeTraverserInstanceofVisitor:
+		phpstan.parser.richParserNodeVisitor: %featureToggles.instanceofType%
 
 services:
 	-
@@ -480,6 +484,9 @@ services:
 	-
 		class: PHPStan\Parser\CurlSetOptArgVisitor
 
+	-
+		class: PHPStan\Parser\TypeTraverserInstanceofVisitor
+
 	-
 		class: PHPStan\Parser\ArrowFunctionArgVisitor
 		tags: