cleanup

phpstan · May 31, 2024 · 4deaf64 · 4deaf64
1 parent f7f434d
commit 4deaf64
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/Type/Php/ConstantFunctionReturnTypeExtension.php b/src/Type/Php/ConstantFunctionReturnTypeExtension.php
@@ -37,10 +37,6 @@ public function getTypeFromFunctionCall(
 
 		$results = [];
 		foreach ($nameType->getConstantStrings() as $constantName) {
-			if ($constantName->getValue() === '') {
-				return null;
-			}
-
 			$expr = $this->constantHelper->createExprFromConstantName($constantName->getValue());
 			if ($expr === null) {
 				return new ErrorType();

diff --git a/src/Type/Php/ConstantHelper.php b/src/Type/Php/ConstantHelper.php
@@ -15,11 +15,12 @@
 class ConstantHelper
 {
 
-	/**
-	 * @param non-empty-string $constantName
-	 */
 	public function createExprFromConstantName(string $constantName): ?Expr
 	{
+		if ($constantName === '') {
+			return null;
+		}
+
 		$classConstParts = explode('::', $constantName);
 		if (count($classConstParts) >= 2) {
 			$fqcn = ltrim($classConstParts[0], '\\');