Skip to content

Commit

Permalink
Error identifiers
Browse files Browse the repository at this point in the history
  • Loading branch information
ondrejmirtes committed May 20, 2023
1 parent d443acc commit 87256f3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Rules/Constants/OverridingConstantRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
$constantReflection->getName(),
$prototype->getDeclaringClass()->getDisplayName(),
$prototype->getName(),
))->nonIgnorable()->build();
))->identifier('classConstant.final')->nonIgnorable()->build();
}

if ($prototype->isPublic()) {
Expand All @@ -82,7 +82,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
$constantReflection->getName(),
$prototype->getDeclaringClass()->getDisplayName(),
$prototype->getName(),
))->nonIgnorable()->build();
))->identifier('classConstant.visibility')->nonIgnorable()->build();
}
} elseif ($constantReflection->isPrivate()) {
$errors[] = RuleErrorBuilder::message(sprintf(
Expand All @@ -91,7 +91,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
$constantReflection->getName(),
$prototype->getDeclaringClass()->getDisplayName(),
$prototype->getName(),
))->nonIgnorable()->build();
))->identifier('classConstant.visibility')->nonIgnorable()->build();
}

if (!$this->checkPhpDocMethodSignatures) {
Expand All @@ -115,7 +115,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
$prototype->getValueType()->describe(VerbosityLevel::value()),
$prototype->getDeclaringClass()->getDisplayName(),
$prototype->getName(),
))->build();
))->identifier('classConstant.type')->build();
}

return $errors;
Expand Down

0 comments on commit 87256f3

Please sign in to comment.