ContainerFactory - always check duplicate files

phpstan · Sep 14, 2024 · 939a715 · 939a715
1 parent f17cf9e
commit 939a715
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/Command/CommandHelper.php b/src/Command/CommandHelper.php
@@ -212,7 +212,7 @@ public static function begin(
 		$paths = array_map(static fn (string $path): string => $currentWorkingDirectoryFileHelper->normalizePath($currentWorkingDirectoryFileHelper->absolutizePath($path)), $paths);
 
 		$analysedPathsFromConfig = [];
-		$containerFactory = new ContainerFactory($currentWorkingDirectory, true);
+		$containerFactory = new ContainerFactory($currentWorkingDirectory);
 		$projectConfig = null;
 		if ($projectConfigFile !== null) {
 			if (!is_file($projectConfigFile)) {

diff --git a/src/DependencyInjection/ContainerFactory.php b/src/DependencyInjection/ContainerFactory.php
@@ -71,7 +71,7 @@ class ContainerFactory
 	private static ?int $lastInitializedContainerId = null;
 
 	/** @api */
-	public function __construct(private string $currentWorkingDirectory, private bool $checkDuplicateFiles = false)
+	public function __construct(private string $currentWorkingDirectory)
 	{
 		$this->fileHelper = new FileHelper($currentWorkingDirectory);
 
@@ -277,10 +277,6 @@ private function detectDuplicateIncludedFiles(
 			return [$normalized, $configArray];
 		}
 
-		if (!$this->checkDuplicateFiles) {
-			return [$normalized, $configArray];
-		}
-
 		$duplicateFiles = array_unique(array_diff_key($normalized, $deduplicated));
 
 		throw new DuplicateIncludedFilesException($duplicateFiles);