Another optimization

phpstan · Oct 8, 2024 · cfbadfd · cfbadfd
1 parent d1a8cbd
commit cfbadfd
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 5 deletions.
diff --git a/src/Parser/VariadicFunctionsVisitor.php b/src/Parser/VariadicFunctionsVisitor.php
@@ -19,6 +19,9 @@ final class VariadicFunctionsVisitor extends NodeVisitorAbstract
 
 	private ?string $inFunction = null;
 
+	/** @var array<string, bool> */
+	public static array $cache = [];
+
 	/** @var array<string, bool> */
 	private array $variadicFunctions = [];
 
@@ -78,6 +81,9 @@ public function leaveNode(Node $node): ?Node
 	public function afterTraverse(array $nodes): ?array
 	{
 		if ($this->topNode !== null && $this->variadicFunctions !== []) {
+			foreach ($this->variadicFunctions as $name => $variadic) {
+				self::$cache[$name] = $variadic;
+			}
 			$functions = array_filter($this->variadicFunctions, static fn (bool $variadic) => $variadic);
 			$this->topNode->setAttribute(self::ATTRIBUTE_NAME, $functions);
 		}

diff --git a/src/Parser/VariadicMethodsVisitor.php b/src/Parser/VariadicMethodsVisitor.php
@@ -29,6 +29,9 @@ final class VariadicMethodsVisitor extends NodeVisitorAbstract
 
 	private ?string $inMethod = null;
 
+	/** @var array<string, array<string, true>> */
+	public static array $cache = [];
+
 	/** @var array<string, array<string, true>> */
 	private array $variadicMethods = [];
 
@@ -108,6 +111,11 @@ public function leaveNode(Node $node): ?Node
 	public function afterTraverse(array $nodes): ?array
 	{
 		if ($this->topNode !== null && $this->variadicMethods !== []) {
+			foreach ($this->variadicMethods as $class => $methods) {
+				foreach ($methods as $name => $variadic) {
+					self::$cache[$class][$name] = $variadic;
+				}
+			}
 			$this->topNode->setAttribute(self::ATTRIBUTE_NAME, $this->variadicMethods);
 		}
 

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -140,6 +140,10 @@ private function isVariadic(): bool
 				return $this->containsVariadicCalls;
 			}
 
+			if (array_key_exists($this->reflection->getName(), VariadicFunctionsVisitor::$cache)) {
+				return $this->containsVariadicCalls = VariadicFunctionsVisitor::$cache[$this->reflection->getName()];
+			}
+
 			$nodes = $this->parser->parseFile($filename);
 			if (count($nodes) > 0) {
 				$variadicFunctions = $nodes[0]->getAttribute(VariadicFunctionsVisitor::ATTRIBUTE_NAME);

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -250,15 +250,22 @@ private function isVariadic(): bool
 				return $this->containsVariadicCalls;
 			}
 
+			$className = $declaringClass->getName();
+			if ($declaringClass->isAnonymous()) {
+				$className = sprintf('%s:%s:%s', VariadicMethodsVisitor::ANONYMOUS_CLASS_PREFIX, $declaringClass->getNativeReflection()->getStartLine(), $declaringClass->getNativeReflection()->getEndLine());
+			}
+			if (array_key_exists($className, VariadicMethodsVisitor::$cache)) {
+				if (array_key_exists($this->reflection->getName(), VariadicMethodsVisitor::$cache[$className])) {
+					return $this->containsVariadicCalls = VariadicMethodsVisitor::$cache[$className][$this->reflection->getName()];
+				}
+
+				return $this->containsVariadicCalls = false;
+			}
+
 			$nodes = $this->parser->parseFile($filename);
 			if (count($nodes) > 0) {
 				$variadicMethods = $nodes[0]->getAttribute(VariadicMethodsVisitor::ATTRIBUTE_NAME);
 
-				$className = $declaringClass->getName();
-				if ($declaringClass->isAnonymous()) {
-					$className = sprintf('%s:%s:%s', VariadicMethodsVisitor::ANONYMOUS_CLASS_PREFIX, $declaringClass->getNativeReflection()->getStartLine(), $declaringClass->getNativeReflection()->getEndLine());
-				}
-
 				if (
 					is_array($variadicMethods)
 					&& array_key_exists($className, $variadicMethods)