allow first "|" and "(" to be escaped

phpstan · Oct 11, 2024 · d08e625 · d08e625
1 parent 23d4dfa
commit d08e625
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/src/Command/IgnoredRegexValidator.php b/src/Command/IgnoredRegexValidator.php
@@ -37,10 +37,10 @@ public function validate(string $regex): IgnoredRegexValidatorResult
 			return new IgnoredRegexValidatorResult([], false, false);
 		}
 
-		if (str_contains($regex, '||')) {
+		if (Strings::match($regex, '~(?<!\\\\)(?:\\\\\\\\)*\|\|~')) {
 			return new IgnoredRegexValidatorResult([], false, true, '||', '\|\|');
 		}
-		if (str_contains($regex, '()')) {
+		if (Strings::match($regex, '~(?<!\\\\)(?:\\\\\\\\)*\(\)~')) {
 			return new IgnoredRegexValidatorResult([], false, true, '()', '\(\)');
 		}
 

diff --git a/tests/PHPStan/Command/IgnoredRegexValidatorTest.php b/tests/PHPStan/Command/IgnoredRegexValidatorTest.php
@@ -100,12 +100,48 @@ public function dataValidate(): array
 				false,
 				false,
 			],
+			[
+				'~(a\()~',
+				[],
+				false,
+				false,
+			],
+			[
+				'~b\\\()~',
+				[],
+				false,
+				true,
+			],
+			[
+				'~(c\\\\\()~',
+				[],
+				false,
+				false,
+			],
 			[
 				'~Result of || is always true.~',
 				[],
 				false,
 				true,
 			],
+			[
+				'~a\||~',
+				[],
+				false,
+				false,
+			],
+			[
+				'~b\\\||~',
+				[],
+				false,
+				true,
+			],
+			[
+				'~c\\\\\||~',
+				[],
+				false,
+				false,
+			],
 			[
 				'#Method PragmaRX\Notified\Data\Repositories\Notified::firstOrCreateByEvent() should return PragmaRX\Notified\Data\Models\Notified but returns Illuminate\Database\Eloquent\Model|null#',
 				[],