array_fill_keys expects array of array-key

[staabm]

refs phpstan/phpstan#11111

---

the also issue mentions

We could also check other invalid accesses:

Reading access: var_dump($array[Language::GER]); --> Cannot access offset of type Language on array
Write: $array[Language::ITA] = 'foobar'; --> Cannot access offset of type Language on array
Unset: unset($array[Language::GER]); --> Cannot unset offset of type Language on array

which makes sense, but a separate problem for a separate PR IMO

[staabm]

while here I used the same fix here - I think array-key better conveys the idea of the type beeing required

this change is here just for consistency with array_fill_keys

[ondrejmirtes]

It's not okay to change the functionMap for this requirement. This needs a custom rule.

Some types outside of int|string can be cast to array key.

[ondrejmirtes]

As for:

We could also check other invalid accesses:

I believe PHPStan already does all of that but if it does not, open a feature request.

[staabm]

I believe PHPStan already does all of that but if it does not, open a feature request.

https://phpstan.org/r/a2c1cff4-0464-4021-bb32-04680554d9bf

you are right, it works already

[staabm]

It's not okay to change the functionMap for this requirement. This needs a custom rule.

Some types outside of int|string can be cast to array key.

would it make sense to create a new "virtual type", like we have with __stringandstringable ?

phpstan-src/src/PhpDoc/TypeNodeResolver.php

Lines 431 to 432 in 04b8403

	case '__stringandstringable':
	return new StringAlwaysAcceptingObjectWithToStringType();

[ondrejmirtes]

I'd say creating a new custom rule is easier than modifying the type system.