Add phpdoc to Exception properties #3511
Open
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Sep 28, 2024
| /** @var string */ | ||
| protected $message; | ||
|
|
||
| /** @var mixed */ |
There was a problem hiding this comment.
The only exception type I am aware of which doesnt has a int code is PDOException
There was a problem hiding this comment.
Yes me too.
But getCode is typed as returning mixed... so I think I have to match this
I'll wait for ondrej decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it was the expected way to solve phpstan/phpstan#11761
Closes phpstan/phpstan#11761