DynamicCallOnStaticMethodsRule - do not report for methods declared o…

…n PHPStanTestCase and TypeInferenceTestCase
phpstan · Mar 29, 2023 · b21c03d · b21c03d
1 parent ce25f06
commit b21c03d
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/Rules/StrictCalls/DynamicCallOnStaticMethodsRule.php b/src/Rules/StrictCalls/DynamicCallOnStaticMethodsRule.php
@@ -7,8 +7,11 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
+use PHPStan\Testing\PHPStanTestCase;
+use PHPStan\Testing\TypeInferenceTestCase;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\Type;
+use function in_array;
 use function sprintf;
 
 class DynamicCallOnStaticMethodsRule implements Rule
@@ -53,6 +56,14 @@ static function (Type $type) use ($name): bool {
 
 		$methodReflection = $type->getMethod($name, $scope);
 		if ($methodReflection->isStatic()) {
+			$prototype = $methodReflection->getPrototype();
+			if (in_array($prototype->getDeclaringClass()->getName(), [
+				TypeInferenceTestCase::class,
+				PHPStanTestCase::class,
+			], true)) {
+				return [];
+			}
+
 			return [sprintf(
 				'Dynamic call to static method %s::%s().',
 				$methodReflection->getDeclaringClass()->getDisplayName(),

diff --git a/tests/Rules/StrictCalls/data/dynamic-calls-on-static-methods.php b/tests/Rules/StrictCalls/data/dynamic-calls-on-static-methods.php
@@ -46,3 +46,16 @@ function () {
 	$classUsingTrait->foo();
 	$classUsingTrait->bar();
 };
+
+class FooTest extends \PHPStan\Testing\TypeInferenceTestCase
+{
+
+	public function doFoo(): void
+	{
+		self::gatherAssertTypes(__FILE__);
+		$this->gatherAssertTypes(__FILE__);
+		self::getContainer();
+		$this->getContainer();
+	}
+
+}