Fix InputBagTypeSpecifyingExtension

phpstan · Sep 26, 2024 · f7d5782 · f7d5782
1 parent 51ab243
commit f7d5782
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Type/Symfony/InputBagTypeSpecifyingExtension.php b/src/Type/Symfony/InputBagTypeSpecifyingExtension.php
@@ -30,7 +30,7 @@ public function getClass(): string
 
 	public function isMethodSupported(MethodReflection $methodReflection, MethodCall $node, TypeSpecifierContext $context): bool
 	{
-		return $methodReflection->getName() === self::HAS_METHOD_NAME && !$context->null();
+		return $methodReflection->getName() === self::HAS_METHOD_NAME && $context->false();
 	}
 
 	public function specifyTypes(MethodReflection $methodReflection, MethodCall $node, Scope $scope, TypeSpecifierContext $context): SpecifiedTypes

diff --git a/tests/Type/Symfony/data/input_bag.php b/tests/Type/Symfony/data/input_bag.php
@@ -7,7 +7,8 @@
 assertType('bool|float|int|string|null', $bag->get('foo'));
 
 if ($bag->has('foo')) {
-	assertType('bool|float|int|string', $bag->get('foo'));
+	// Because `has` rely on `array_key_exists` we can still have set the NULL value.
+	assertType('bool|float|int|string|null', $bag->get('foo'));
 	assertType('bool|float|int|string|null', $bag->get('bar'));
 } else {
 	assertType('null', $bag->get('foo'));