Command::addOption()'s $default expects wrong array format

[Majkl578]

Symfony 4.0 documents Symfony\Component\Console\Command\Command::addOption()'s 5th parameter $default as mixed.

When using default values with InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL mode, the $default parameter expects array<int, string>|null.
This is wrong because keys are irrelevant and leads to error like this:

Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<int, string>|null, array<string> given.

Happens when $default is given an array documented as string[].

Sample code:

/** @var string[] $default */
$default = getSomeDefaults();

$command->addOption(
	'foo',
	null,
	InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL,
	'foo bar',
	$default
);

This error pops up at level 0 only with this extension enabled, not without it.

[lookyman]

Yep, I see. Thanks, I'll fix it asap.

[ondrejmirtes]

Level 0? Argument types are not checked until level 5.

On Thu, 2 May 2019 at 06:42, Lukáš Unger ***@***.***> wrote: Yep, I see. Thanks, I'll fix it asap. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOF6RUC6SZM5PJVE3IDPTLHTTANCNFSM4HJ5PI4Q> .

-- Ondřej Mirtes

[Majkl578]

@ondrejmirtes Yes, it's strange but it's really reported on level 0 already.
Versions:

phpstan/phpstan                                  0.11.5
phpstan/phpstan-doctrine                         0.11.2
phpstan/phpstan-phpunit                          0.11
phpstan/phpstan-symfony                          0.11.5

[lookyman]

That's because the rule doesn't care about levels. I might change that too.

[ondrejmirtes]

You can inject the same parameters PHPStan uses in config.level5.neon.

On Thu, 2 May 2019 at 09:57, Lukáš Unger ***@***.***> wrote: That's because the rule doesn't care about levels. I might change that too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOF2FYIL4RJPGWMXE6LPTL6ONANCNFSM4HJ5PI4Q> .

-- Ondřej Mirtes

[lookyman]

Fixed in c4da70e

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.