Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recursive types to Serializer #35

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Feb 13, 2019

As correctly pointed out by @jvasseur, it's possible to have arrays of arrays.

#34 (comment)

Of course really we should check what normalizers are in the container, and only if ArrayNormalizer is active support this, and possibly be able to say what objects are deserializable,

@lookyman
Copy link
Collaborator

We can cross that bridge when we get to it (e.g. when someone runs into that and opens an issue 😊).

@lookyman lookyman merged commit 1ef2927 into phpstan:master Feb 14, 2019
@mcfedr
Copy link
Contributor Author

mcfedr commented Feb 14, 2019

We can cross that bridge when we get to it (e.g. when someone runs into that and opens an issue 😊).

Yes, when I stated writing this i thought about it, and decided it was extra complication for very little gain...

@mcfedr mcfedr deleted the serializer branch February 14, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants