Fix lint errors

phramework · Jan 29, 2017 · e38130b · e38130b
1 parent b79bba6
commit e38130b
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 51 deletions.
diff --git a/src/AbstractEndpoint.php b/src/AbstractEndpoint.php
@@ -1,5 +1,5 @@
 <?php
-namespace Phramework\JSONAPI\Client;
+declare(strict_types=1);
 /*
  * Copyright 2016-2017 Xenofon Spafaridis
  *
@@ -15,6 +15,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+namespace Phramework\JSONAPI\Client;
+
 use Phramework\JSONAPI\Client\Directive\Directive;
 use Phramework\JSONAPI\Client\Exceptions\ResponseException;
 use Phramework\JSONAPI\Client\Response\Collection;
@@ -30,7 +32,7 @@ abstract class AbstractEndpoint
      * @return Collection
      * @throws ResponseException
      */
-    public abstract function get(
+    abstract public function get(
         Directive ...$directives
     ) : Collection;
 
@@ -40,7 +42,7 @@ public abstract function get(
      * @return JSONAPIResource
      * @throws ResponseException
      */
-    public abstract function getById(
+    abstract public function getById(
         string $id,
         Directive ...$directives
     ) : JSONAPIResource;
@@ -52,7 +54,7 @@ public abstract function getById(
      * @return JSONAPIResource
      * @throws ResponseException
      */
-    public abstract function post(
+    abstract public function post(
         \stdClass $attributes = null,
         RelationshipsData  $relationships = null,
         Directive ...$directives
@@ -66,7 +68,7 @@ public abstract function post(
      * @return JSONAPIResource
      * @throws ResponseException
      */
-    public abstract function patch(
+    abstract public function patch(
         string $id,
         \stdClass $attributes = null,
         RelationshipsData  $relationships = null,
@@ -81,7 +83,7 @@ public abstract function patch(
      * @return JSONAPIResource
      * @throws ResponseException
      */
-    public abstract function delete(
+    abstract public function delete(
         string $id,
         \stdClass $attributes = null,
         RelationshipsData  $relationships = null,
@@ -96,7 +98,7 @@ public abstract function delete(
      * @return JSONAPIResource
      * @throws ResponseException
      */
-    public abstract function put(
+    abstract public function put(
         string $id,
         \stdClass $attributes = null,
         RelationshipsData  $relationships = null,

diff --git a/src/Directive/Directive.php b/src/Directive/Directive.php
@@ -27,7 +27,8 @@ abstract class Directive
     /**
      * @return string
      */
-    public function getURL(): string {
+    public function getURL(): string
+    {
         return '';
     }
 

diff --git a/src/Directive/Page.php b/src/Directive/Page.php
@@ -87,4 +87,4 @@ public function getLimit()
     {
         return $this->limit;
     }
-}
+}
diff --git a/src/Endpoint/Get.php b/src/Endpoint/Get.php
@@ -72,4 +72,4 @@ public function get(
 
         return (new Collection($response));
     }
-}
+}
diff --git a/src/Response/Collection.php b/src/Response/Collection.php
@@ -82,4 +82,4 @@ public function offsetGet($offset)
     {
         return isset($this->data[$offset]) ? $this->data[$offset] : null;
     }
-}
+}
diff --git a/src/Response/Response.php b/src/Response/Response.php
@@ -51,7 +51,6 @@ public function __construct(ResponseInterface $response)
         $body = json_decode($response->getBody()->getContents());
 
         if ($body) {
-
             $members = array_keys(get_object_vars($this));
 
             foreach ($members as $member) {

diff --git a/tests/src/Endpoint/BaseEndpoint.php → tests/APP/BaseEndpoint.php b/tests/src/Endpoint/BaseEndpoint.php → tests/APP/BaseEndpoint.php
@@ -15,10 +15,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-namespace Phramework\JSONAPI\Client;
+namespace Phramework\JSONAPI\APP;
 
 use Phramework\JSONAPI\Client\Directive\IncludeRelationship;
 use Phramework\JSONAPI\Client\Directive\Page;
+use Phramework\JSONAPI\Client\Endpoint;
 
 trait BaseEndpoint
 {

diff --git a/tests/src/Endpoint/EndpointPatchTest.php b/tests/src/Endpoint/EndpointPatchTest.php
@@ -17,8 +17,7 @@
  */
 namespace Phramework\JSONAPI\Client;
 
-require_once __DIR__ . '/BaseEndpoint.php';
-
+use Phramework\JSONAPI\APP\BaseEndpoint;
 use Phramework\JSONAPI\Client\Response\JSONAPIResource;
 
 /**
@@ -38,16 +37,7 @@ public function testPost()
             (object) [
                 'title' => 'do this from phpunit',
                 'body' => 'do this from phpunit - body',
-            ]/*,
-            (new RelationshipsData())
-                ->append(
-                    'tag',
-                    '1'
-                )
-                ->append(
-                    'tag',
-                    '2'
-                )*/
+            ]
         );
 
         $this->markTestIncomplete();

diff --git a/tests/src/Endpoint/GetByIdTest.php b/tests/src/Endpoint/GetByIdTest.php
@@ -17,8 +17,7 @@
  */
 namespace Phramework\JSONAPI\Client;
 
-require_once __DIR__ . '/BaseEndpoint.php';
-
+use Phramework\JSONAPI\APP\BaseEndpoint;
 use Phramework\JSONAPI\Client\Directive\IncludeRelationship;
 use Phramework\JSONAPI\Client\Directive\Page;
 use Phramework\JSONAPI\Client\Exceptions\ResponseException;
@@ -34,7 +33,6 @@ class GetByIdTest extends \PHPUnit_Framework_TestCase
     use BaseEndpoint;
 
     /**
-     * @param string $id
      * @covers ::getById
      */
     public function testGeyById()

diff --git a/tests/src/Endpoint/GetTest.php b/tests/src/Endpoint/GetTest.php
@@ -17,8 +17,7 @@
  */
 namespace Phramework\JSONAPI\Client;
 
-require_once __DIR__ . '/BaseEndpoint.php';
-
+use Phramework\JSONAPI\APP\BaseEndpoint;
 use Phramework\JSONAPI\Client\Directive\IncludeRelationship;
 use Phramework\JSONAPI\Client\Directive\Page;
 use Phramework\JSONAPI\Client\Exceptions\ResponseException;

diff --git a/tests/src/Endpoint/PostTest.php b/tests/src/Endpoint/PostTest.php
@@ -17,11 +17,7 @@
  */
 namespace Phramework\JSONAPI\Client;
 
-require_once __DIR__ . '/BaseEndpoint.php';
-
-use Phramework\JSONAPI\Client\Directive\IncludeRelationship;
-use Phramework\JSONAPI\Client\Directive\Page;
-use Phramework\JSONAPI\Client\Exceptions\ResponseException;
+use Phramework\JSONAPI\APP\BaseEndpoint;
 use Phramework\JSONAPI\Client\Response\JSONAPIResource;
 
 /**
@@ -40,17 +36,8 @@ public function testPost()
         $post = $this->endpoint->post(
             (object) [
                 'title' => 'do this from phpunit',
-                'body' => 'do this from phpunit - body',
-            ]/*,
-            (new RelationshipsData())
-                ->append(
-                    'tag',
-                    '1'
-                )
-                ->append(
-                    'tag',
-                    '2'
-                )*/
+                'body'  => 'do this from phpunit - body',
+            ]
         );
 
         $this->markTestIncomplete();

diff --git a/tests/src/EndpointTest.php b/tests/src/EndpointTest.php
@@ -16,8 +16,3 @@
  * limitations under the License.
  */
 namespace Phramework\JSONAPI\Client;
-
-use Phramework\JSONAPI\Client\Directive\IncludeRelationship;
-use Phramework\JSONAPI\Client\Directive\Page;
-use Phramework\JSONAPI\Client\Exceptions\ResponseException;
-use Phramework\JSONAPI\Client\Response\JSONAPIResource;