Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/forge bin as lib #13

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat/forge bin as lib #13

merged 1 commit into from
Apr 29, 2024

Conversation

0xgregthedev
Copy link
Collaborator

@0xgregthedev 0xgregthedev commented Apr 29, 2024

convert forge/bin to a lib to export code for reuse

@0xgregthedev 0xgregthedev changed the base branch from master to develop April 29, 2024 18:51
@0xgregthedev 0xgregthedev marked this pull request as ready for review April 29, 2024 18:54
@Qwuke Qwuke self-requested a review April 29, 2024 18:56
Copy link
Collaborator

@Qwuke Qwuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should probably add an explanation in the forge/Cargo.toml explaining why the binary is commented out, but I think it's fine to merge as is.

@Qwuke Qwuke merged commit 883689f into develop Apr 29, 2024
@odyslam
Copy link
Collaborator

odyslam commented Apr 29, 2024

Why do we need the bin source files?

@0xgregthedev
Copy link
Collaborator Author

Why do we need the bin source files?

This allows us to utilize our fork for the FilterArgs struct that is used when setting up the runner, instead of yoinking the code.
It will also allow us to potentially do the same with TestArgs and InstallArgs, making those features much easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant tests: preserve_state is not respected when fail_on_revert = false
3 participants