Skip to content

Commit

Permalink
Fix issues with cargo-update workflow (#1244)
Browse files Browse the repository at this point in the history
* Fix issues with cargo-update workflow

This patch addresses many little issues:

- The backtick (`) character was being interpreted as shell expansion in
  the `git commit` command
- The `noreply` email for `phylum-bot` did not include the user ID
- This repository does not use Conventional Commits, so the `build:`
  prefix was unnecessary

* Use "phylum-bot" for committer name

Co-authored-by: Charles Coggins <maxrake@users.noreply.github.com>

---------

Co-authored-by: Charles Coggins <maxrake@users.noreply.github.com>
  • Loading branch information
kylewillmon and maxrake authored Oct 2, 2023
1 parent 13e019a commit 3300c62
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cargo-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
id: commit
continue-on-error: true
run: |
git config user.name 'Phylum Bot'
git config user.email 'phylum-bot@users.noreply.github.com'
git commit -a -m "build: Bump `Cargo.lock` dependencies"
git config user.name 'phylum-bot'
git config user.email '69485888+phylum-bot@users.noreply.github.com'
git commit -a -m "Bump dependencies"
git push --force origin HEAD:auto-cargo-update
- name: Create Pull Request
Expand All @@ -37,6 +37,6 @@ jobs:
repo: context.repo.repo,
head: "auto-cargo-update",
base: context.ref,
title: "build: Bump `Cargo.lock` dependencies",
body: "Bump dependencies in `Cargo.lock` for all SemVer-compatible updates.",
title: "Bump dependencies",
body: "Bump dependencies for all SemVer-compatible updates.",
});

0 comments on commit 3300c62

Please sign in to comment.