Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manifest filtering for different ecosystems #1247

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Fix manifest filtering for different ecosystems #1247

merged 4 commits into from
Oct 6, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Oct 6, 2023

This fixes an issue where manifests would get filtered out with a lockfile of a different ecosystem being present in a parent directory.

Closes #1245.

@cd-work
Fix manifest filtering for different ecosystems
8c75ce4 
This fixes an issue where manifests would get filtered out with a
lockfile of a different ecosystem being present in a parent directory.

Closes #1245.
@cd-work cd-work requested a review from a team as a code owner October 6, 2023 17:02
@cd-work cd-work requested a review from kylewillmon October 6, 2023 17:02
kylewillmon
kylewillmon requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@kylewillmon kylewillmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG entry. Otherwise, looks good

@cd-work cd-work requested a review from kylewillmon October 6, 2023 18:36
kylewillmon
kylewillmon previously approved these changes Oct 6, 2023
View reviewed changes
@maxrake maxrake self-requested a review October 6, 2023 18:42
maxrake
maxrake approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were tested locally and appear to work as expected. LGTM.

@cd-work cd-work merged commit d4353dc into main Oct 6, 2023
13 checks passed
@cd-work cd-work deleted the manifest_filtering branch October 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@kylewillmon kylewillmon kylewillmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifests are removed when any lockfile exists
3 participants
@cd-work @kylewillmon @maxrake