Fix requirements parsing with index URL option #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrake
requested changes
Oct 11, 2023
kylewillmon
requested changes
Oct 11, 2023
kylewillmon
previously approved these changes
Oct 11, 2023
maxrake
requested changes
Oct 11, 2023
This reverts commit 2f0660a.
kylewillmon
reviewed
Oct 11, 2023
maxrake
previously approved these changes
Oct 11, 2023
There was a problem hiding this comment.
The changes were tested locally and appear to work as intended. There is still the possibility that a -f/--find-links option is included in the requirements file, which should similarly be treated as a third party dependency source. However, that case may be able to wait until it is clear that it causes issues for users.
maxrake
reviewed
Oct 11, 2023
kylewillmon
reviewed
Oct 11, 2023
maxrake
approved these changes
Oct 11, 2023
cd-work
commented
Oct 11, 2023
| // primary one. | ||
| if let Some(index_url) = line | ||
| .strip_prefix("--index-url") | ||
| .and_then(|line| line.strip_prefix(['=', ' '])) |
There was a problem hiding this comment.
Just to make sure, I'd assume --index-url = https://whatever.com is not valid?
There was a problem hiding this comment.
Correct...that form is not valid:
There was a problem hiding this comment.
There are other weird edge cases... But I don't want to waste a bunch of time on them...
> cat req.txt
--index-url https://pypi.org/simple AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
pyyaml
> pip install --dry-run -r req.txt
Collecting pyyaml
Downloading PyYAML-6.0.1-cp310-cp310-macosx_11_0_arm64.whl (169 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 169.3/169.3 kB 2.1 MB/s eta 0:00:00
Would install PyYAML-6.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.