Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PyPI local versions #1419

Merged
merged 3 commits into from
May 13, 2024
Merged

Add support for PyPI local versions #1419

merged 3 commits into from
May 13, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented May 13, 2024

Closes #1416.

@cd-work cd-work requested a review from a team as a code owner May 13, 2024 15:38
@cd-work cd-work requested a review from mathew-horner May 13, 2024 15:39
mathew-horner
mathew-horner previously approved these changes May 13, 2024
View reviewed changes
maxrake
maxrake requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were reviewed and tested locally.

tests/fixtures/requirements-locked.txt Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lockfile/src/parsers/pypi.rs Show resolved Hide resolved
@cd-work cd-work requested a review from maxrake May 13, 2024 16:25
@cd-work cd-work enabled auto-merge (squash) May 13, 2024 16:34
maxrake
maxrake approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were tested locally and work as intended. LGTM.

@cd-work cd-work merged commit 16ab00e into main May 13, 2024
14 checks passed
@cd-work cd-work deleted the local_version branch May 13, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@mathew-horner mathew-horner mathew-horner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyPI parser does not handle local version identifiers
3 participants
@cd-work @maxrake @mathew-horner