Build without sandboxing on Windows #1485
Conversation
There was a problem hiding this comment.
I like the choice of making this a platform-specific thing rather than a feature, makes it more about not being possible rather than making it sound like sandboxing is a feature you might want to disable in certain scenarios.
I've got one minor nit but I'm fine with it going either way.
|
I'm still reviewing...but there are three warnings on the Windows job. Do those need to be accounted for here? If so, then enabling warnings as errors should also be pursued. |
They're pretty simple to handle, so sure.
This might just anger people... So I'd rather not do that for now. |
Roger that. Maybe case in point...there are two new warnings now. |
With this patch, all sandboxing code is guarded by
#[cfg(unix)].