Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate check option naming #1546

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix certificate check option naming #1546

merged 2 commits into from
Dec 2, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Nov 29, 2024

This fixes an inconsistency between the ignore_certs configuration option and the --no-check-certificate CLI flag by changing the CLI flag to be --ignore-certs with an alias for the old version.

Closes #480.

This fixes an inconsistency between the `ignore_certs` configuration
option and the `--no-check-certificate` CLI flag by changing the CLI
flag to be `--ignore-certs` with an alias for the old version.

Closes #480.
@cd-work cd-work requested a review from a team as a code owner November 29, 2024 13:25
@cd-work cd-work requested a review from matt-phylum November 29, 2024 13:25
@cd-work cd-work self-assigned this Nov 29, 2024
Copy link
Contributor

@matt-phylum matt-phylum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-check-certificate is the name of the parameter used by wget, but if it's just wget that doesn't seem like a standard that we'd want to stick with. I like when the name contains something like "insecure", but it's probably okay.

@cd-work cd-work merged commit db1e22c into main Dec 2, 2024
17 checks passed
@cd-work cd-work deleted the cert_stuff branch December 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_certs is plural but --no-check-certificate is singular
2 participants