Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nothing, but follows #222 .
The code in master is nice, but there are cases that might not be handled.
For instance, if
'mmHg'
(Which is a non-BIDS unit we might end up having, since it's the standard unit for some gas applications e.g. CVR) is passed as an argument tobidsify_units
, it would returnmmhg
. The same can be said forBigV
orMMLIE
(examples adapted from the test). It's not a huge deal, but if it's not a SI unit, at least we should leave it as it is without changing it.There's still cases that are not supported (e.g. non-SI term
plethora
would return 'plethorA'), but that's for another day (and I hope no one would measure "0.56 plethora of physiological activity" in the meantime).Proposed Changes