Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference API #231

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Update reference API #231

merged 1 commit into from
Jun 11, 2020

Conversation

rmarkello
Copy link
Member

Closes #??

Proposed Changes

  • Adds info to reference API

What other functions / classes should be added to the API? Happy to add whatever but I don't think everything needs to be on it.

@rmarkello rmarkello added the Documentation This issue or PR is about the documentation label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files           8        8           
  Lines         679      679           
=======================================
  Hits          636      636           
  Misses         43       43           

@smoia
Copy link
Member

smoia commented Jun 11, 2020

I didn't try to build it locally yet, but I think it's ok!

I wonder if it makes sense to add a heuristic file as well?

What do you think?

@rmarkello
Copy link
Member Author

Like, a template heuristic file? Or the function for processing the heuristic file (i.e., use_heur() or whatever it's called)?

In my mind the API should just be documenting functions in the codebase, so if you were suggesting the former I'd err on the side of no. But I can add the latter, if you'd like?

@smoia
Copy link
Member

smoia commented Jun 11, 2020

Mmm, yeah, you're right. I don't think it's necessary to document the latter though - I think there's everything we need!

@smoia smoia self-assigned this Jun 11, 2020
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the PR!
If you're happy with it, you can merge it!

@rmarkello rmarkello merged commit acb963c into physiopy:master Jun 11, 2020
@rmarkello rmarkello deleted the apiref branch June 11, 2020 20:28
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation This issue or PR is about the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants