-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for participants_file and append_list_as_row #254
Conversation
I'm assigning Eneko to review this PR as we discussed. No pressure. I still have to add the tests for the participants file. |
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 93.39% 94.38% +0.98%
==========================================
Files 9 9
Lines 772 783 +11
==========================================
+ Hits 721 739 +18
+ Misses 51 44 -7
|
…est_participants
…2bids into test_participants
Both new functions should be checked and up to date with master. I'm not sure about the last tests in |
@sangfrois I added the remaining test. It was just a matter of repeating the last one you wrote to check that the subject was already in the file. I don't know why Travis is complaining about numpy today. It probably has something to do with the lowest numpy version we support. Anyway, the test pass and coverage increases significantly, so good job! 🙌🏻 Let's see if we fix the issue in Travis and then we review and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice unit tests
Adresses #252 by testing new functions in
bids.py
andutils.py
Proposed Changes
append_list_as_row()
participants_file()
This would lead to increased coverage 👍