Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for the multi run pipeline #266

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Add integration test for the multi run pipeline #266

merged 1 commit into from
Jun 24, 2020

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Jun 23, 2020

I does not close the issue on adding tests for the multi run pipeline as we still have to add unit tests for split4phys.py. I will tackle that in another PR if no one else does it before. The main objective of this PR is to get our code coverage above 90% for OHBM.

Proposed Changes

  • The title says it all.

@eurunuela eurunuela requested a review from smoia June 23, 2020 18:27
@eurunuela eurunuela requested a review from vinferrer June 23, 2020 18:28
@eurunuela eurunuela added the Testing This is for testing features, writing tests or producing testing code label Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #266 into master will increase coverage by 4.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   89.19%   93.61%   +4.41%     
==========================================
  Files          10       10              
  Lines         861      861              
==========================================
+ Hits          768      806      +38     
+ Misses         93       55      -38     
Impacted Files Coverage Δ
phys2bids/phys2bids.py 86.50% <0.00%> (+6.13%) ⬆️
phys2bids/slice4phys.py 97.14% <0.00%> (+80.00%) ⬆️

@eurunuela eurunuela assigned vinferrer and unassigned smoia Jun 24, 2020
Copy link
Collaborator

@vinferrer vinferrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@vinferrer vinferrer merged commit a2493bf into physiopy:master Jun 24, 2020
@eurunuela eurunuela deleted the split_tests branch August 25, 2020 05:50
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. Testing This is for testing features, writing tests or producing testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants