Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start of sampling time is now the same for all frequencies #283

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Start of sampling time is now the same for all frequencies #283

merged 11 commits into from
Aug 19, 2020

Conversation

vinferrer
Copy link
Collaborator

Closes #282

Proposed Changes

  • Now the sampling start time is the same for all frequencies blueprint output objects.
  • time channel is now in all frequencies blueprint output objects down-sampled to the appropriate frequency

@vinferrer vinferrer added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Aug 11, 2020
@vinferrer vinferrer requested a review from smoia August 18, 2020 08:47
@eurunuela eurunuela changed the title Start sampling time same for all frequency Start of sampling time is now the same for all frequencies Aug 18, 2020
eurunuela
eurunuela requested changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just update the comment and we're good to go!

phys2bids/phys2bids.py Outdated Show resolved Hide resolved
@vinferrer @eurunuela
Update phys2bids/phys2bids.py
df3c05e 
Co-authored-by: Eneko Uruñuela <13706448+eurunuela@users.noreply.github.com>
eurunuela
eurunuela approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinferrer !

@eurunuela eurunuela mentioned this pull request Aug 18, 2020
Merged
@vinferrer vinferrer merged commit bc04f10 into physiopy:master Aug 19, 2020
@vinferrer vinferrer deleted the start_time branch September 17, 2020 13:32
@smoia smoia added released This issue/pull request has been released. BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) and removed BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

@smoia smoia Awaiting requested review from smoia

Assignees

@eurunuela eurunuela

Labels
BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampling starting time is different in frequency outputs
3 participants
@vinferrer @eurunuela @smoia