Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #294

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Fix linting errors #294

merged 11 commits into from
Aug 19, 2020

Conversation

eurunuela
Copy link
Collaborator

Closes #293

Proposed Changes

  • Fix linting errors around the entire package.

@eurunuela eurunuela added the Refactoring Improve nonfunctional attributes label Aug 19, 2020
@eurunuela eurunuela marked this pull request as ready for review August 19, 2020 16:10
@vinferrer
Copy link
Collaborator

where are the other tests?

@eurunuela
Copy link
Collaborator Author

where are the other tests?

I think CircleCI went a bit crazy with so many consecutive commits. They should start appearing now that I've canceled the tests on previous commits.

@eurunuela
Copy link
Collaborator Author

Style check passed! Yay! 🎉

@vinferrer
Copy link
Collaborator

LGTM!!!!

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files           9        9           
  Lines         842      842           
=======================================
  Hits          782      782           
  Misses         60       60           
Impacted Files Coverage Δ
phys2bids/bids.py 98.05% <ø> (ø)
phys2bids/interfaces/txt.py 98.67% <ø> (ø)
phys2bids/slice4phys.py 97.14% <ø> (ø)
phys2bids/utils.py 92.10% <ø> (ø)
phys2bids/viz.py 93.75% <ø> (ø)

@eurunuela eurunuela merged commit ff2e0e3 into physiopy:master Aug 19, 2020
@tsalo
Copy link
Member

tsalo commented Aug 19, 2020

@eurunuela Have you been cancelling old builds manually?

To do it automatically, on the phys2bids CircleCI page, go to Project Settings --> Advanced --> turn on Auto-cancel Redundant Builds

@eurunuela
Copy link
Collaborator Author

Thank you so much @tsalo ! That will make silly PRs like this one even smoother.

@eurunuela eurunuela deleted the fix/lint branch August 25, 2020 05:19
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Improve nonfunctional attributes released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are linting error that need to be addressed
4 participants