Reload blocking mode independently of incoming queries #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
reviewed
Mar 1, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
force-pushed
the
tweak/blockind_status
branch
from
2fa54b2 to
29cc882
Compare
yubiuser
approved these changes
Mar 8, 2022
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This was referenced Apr 20, 2022
1 task
1 task
This was referenced Apr 24, 2022
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
So far, FTL defers reading the blocking mode until the new query arrived, however, on very quiet systems, there can be a notable gap in between changing the status and FTL picking it up on the next query. This optimization has the side-effect of reporting an incorrect blocking status after changing the status until the next query arrives. This PR changes lazy loading of the blocking status (enabled/disabled) to instantaneous.
The constant
RELOAD_BLOCKINGMODEis renamed toRELOAD_BLOCKINGSTATUSbecause this is what it actually does.