-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query counts #1322
Merged
Merged
Fix query counts #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e we subtract from the previous reply counter when setting a new status Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
fix/negative_replies
branch
from
March 26, 2022 12:24
83227e0
to
8734b60
Compare
Force-pushed to reword commit messages, no code changes involved. |
yubiuser
reviewed
Mar 29, 2022
DL6ER
commented
Apr 2, 2022
Confirmed working. All three numbers still match on my Pi-hole after 7 days of uninterrupted operation. {
"domains_being_blocked": 185134,
"dns_queries_today": 22678, <-------------------
"ads_blocked_today": 2027,
"ads_percentage_today": 8.938178,
"unique_domains": 3613,
"queries_forwarded": 9791,
"queries_cached": 10633,
"clients_ever_seen": 83,
"unique_clients": 28,
"dns_queries_all_types": 22678, <-------------------
"reply_UNKNOWN": 313,
"reply_NODATA": 6403,
"reply_NXDOMAIN": 214,
"reply_CNAME": 2659,
"reply_IP": 12272,
"reply_DOMAIN": 288,
"reply_RRNAME": 9,
"reply_SERVFAIL": 0,
"reply_REFUSED": 0,
"reply_NOTIMP": 0,
"reply_OTHER": 0,
"reply_DNSSEC": 520,
"reply_NONE": 0,
"reply_BLOB": 0,
"dns_queries_all_replies": 22678, <-------------------
"privacy_level": 0,
"status": "enabled",
"gravity_last_updated": {
"file_exists": true,
"absolute": 1648348866,
"relative": {
"days": 6,
"hours": 9,
"minutes": 43
}
}
} |
5 tasks
yubiuser
approved these changes
Apr 2, 2022
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This was referenced Apr 20, 2022
1 task
1 task
This was referenced Apr 24, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Further fixes to ensure the independent quantities
dns_queries_today
,dns_queries_all_types
and the newly introduceddns_queries_all_replies
are indeed identical. See #1315 for further details.