Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overtime computation #1327

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix overtime computation #1327

merged 1 commit into from
Apr 8, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 8, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR fixes a logic quirk introduced in #1312. master isn't affected. More details can be found in the mentioned PR causing this.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team April 8, 2022 05:18
@yubiuser yubiuser merged commit e4e397d into development Apr 8, 2022
@yubiuser yubiuser deleted the fix/overTime branch April 8, 2022 05:22
@DL6ER DL6ER changed the title Fix overtime computation logic broken in PR #1312 Fix overtime computation Apr 8, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants