Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove PID and PORT file during shutdown" #1384

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 10, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Do not try to remove PID and PORT files as the user pihole cannot do this. Write permissions on the files themselves are only sufficient to truncate the files, removing them needs write permissions on the containing directory (/run) which isn't the case, usually.

This PR reverts #1328

@DL6ER DL6ER added the Bugfix label Jul 10, 2022
@DL6ER DL6ER requested a review from a team July 10, 2022 13:02
@PromoFaux PromoFaux merged commit 351999c into development Jul 12, 2022
@PromoFaux PromoFaux deleted the revert-1328-tweak/removePIDfile branch July 12, 2022 15:05
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftl-v5-16-2-broken/57181/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants