Allow for empty strings to be passed into FTLCONF_ environment variables #1288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
In order to set FTL's
DBFILE
value to empty, one has to pass in the variable as in asFTLCONF_DBFILE: ""
, however this was parsed wrong by thesed
command which was expected one or more chars between the"
s.See https://discourse.pi-hole.net/t/installing-a-pi-hole-while-reducing-the-writing-on-the-sd-card/60519/11?u=promofaux
This fixes it by allowing the value between
"
s to also be emptyBy submitting this pull request, I confirm the following:
git rebase
)