Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pihole checkout for development checkout #227

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Conversation

diginc
Copy link
Collaborator

@diginc diginc commented Jan 30, 2018

And add FTL

@diginc diginc merged commit d5db4f4 into dev Jan 31, 2018
@diginc diginc deleted the use_pihole_checkout branch January 31, 2018 16:26
@HorayNarea
Copy link

FTL is not starting correctly since I updated to the newest dev-image (which contains this merged PR)
It just keeps spamming the log with "Starting pihole-FTL" and never gets started -> no data shown in the webinterface

@HorayNarea
Copy link

HorayNarea commented Jan 31, 2018

seems like the directory for its socket is missing:

docker exec -it pihole /bin/bash
ls /var/run/pihole
ls: cannot access '/var/run/pihole': No such file or directory

and pihole-FTL debug also says: Error on binding on Unix socket /var/run/pihole/FTL.sock: No such file or directory

@diginc
Copy link
Collaborator Author

diginc commented Jan 31, 2018

#227 Had a fix for that one @HorayNarea

I see where I am now :D woops.

492b6f6 should have created that directory. You maybe running into a centos/fedora bug detailed in another issue

@HorayNarea
Copy link

Well my docker host is an Archlinux… :D

@diginc
Copy link
Collaborator Author

diginc commented Jan 31, 2018

Is it doing any sort of weird /var mounts like described in #217 ? That is what fedora was doing and it was breaking the expected directory structure of /var. You could do a docker inspect on your container to see if there's a volume mount for /var that you did not add.

docker pull diginc/pi-hole:debian_dev ; docker run -it -e ServerIP="1.2.3.4" -v /dev/null:/etc/pihole/adlists.default -e PYTEST="True" diginc/pi-hole:debian_dev bash
...
root@f0adfa825680:/# ls -lat /var/run/pihole
total 8
drwxr-xr-x  2 root root 4096 Jan 31 19:50 .
drwxr-xr-x 11 root root 4096 Jan 31 19:50 ..
srwxr-xr-x  1 root root    0 Jan 31 19:50 FTL.sock

@HorayNarea
Copy link

HorayNarea commented Jan 31, 2018

Nope, just /etc/pihole and /etc/dnsmasq.d
bildschirmfoto vom 2018-01-31 21-05-25

If it helps: my docker version is 18.01.0-ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants