Removed inline styling and fixed eslint errors

Signed-off-by: Anthony de Jong <11158888+anthony-de-jong@users.noreply.github.com>
pi-hole · May 23, 2022 · 8ebd5d2 · 8ebd5d2
1 parent 99c2ad4
commit 8ebd5d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/groups-domains.php b/groups-domains.php
@@ -49,7 +49,7 @@
                                     <div class="form-group">
                                         <label for="new_domain">Domain:</label>
                                         <input id="new_domain" type="url" class="form-control active" placeholder="Domain to be added" autocomplete="off" spellcheck="false" autocapitalize="none" autocorrect="off">
-                                        <div id="suggest_domains" style="display: none; overflow-x: auto;"></div>
+                                        <div id="suggest_domains" class="table-responsive no-border"></div>
                                     </div>
                                 </div>
                                 <div class="col-md-6 form-group">

diff --git a/scripts/pi-hole/js/groups-domains.js b/scripts/pi-hole/js/groups-domains.js
@@ -88,15 +88,17 @@ function showSuggestDomains(event) {
         return;
       }
 
+      // URL is not supported in IE11, but we are in a try-block so we can ignore it
+      // eslint-disable-next-line compat/compat
       var parts = new URL(clipboardData).hostname.split(".");
-      var table = $('<table style="text-align: right !important">');
+      var table = $("<table>");
 
       for (var i = 0; i < parts.length - 1; ++i) {
         var hostname = parts.slice(i).join(".");
 
         table.append(
           $("<tr>")
-            .append($('<td class="text-nowrap">').text(i === 0 ? "Did you mean" : "or"))
+            .append($('<td class="text-nowrap text-right">').text(i === 0 ? "Did you mean" : "or"))
             .append($("<td>").append(createButton(hostname)))
         );
       }
@@ -108,7 +110,7 @@ function showSuggestDomains(event) {
           newDomainEl.one("input", hideSuggestDomains);
         });
       });
-    } catch (ex) {
+    } catch {
       hideSuggestDomains();
     }
   });