Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings > Privacy does not show updated as expected #1783

Closed
thebeanieman opened this issue Apr 18, 2021 · 10 comments · Fixed by #2130
Closed

Settings > Privacy does not show updated as expected #1783

thebeanieman opened this issue Apr 18, 2021 · 10 comments · Fixed by #2130

Comments

@thebeanieman
Copy link

Versions

Pi-hole version is v5.3.1 (Latest: v5.3.1)
AdminLTE version is v5.5 (Latest: v5.5)
FTL version is v5.8 (Latest: v5.8)

Platform

  • OS and version: Raspbian GNU/Linux 10 (buster) debian
  • Platform: Raspberry Pi

Expected behavior

I visit the page Settings > Privacy (/admin/settings.php?tab=privacy)
The DNS resolver privacy level is set to Show everything and record everything
I change it to Anonymous mode and press Apply

The page should refresh and show the DNS resolver privacy level is set to Anonymous mode

Actual behavior / bug

The page refreshes, a blue bar shows saying "Info - The privacy level has been increased" but the DNS resolver privacy level is still Show everything and record everything

When I manually refresh the page, the correct DNS resolver privacy level is showing.

The same happens in reverse.

Steps to reproduce

Steps to reproduce the behavior:

As above

Debug Token

@dschaper dschaper transferred this issue from pi-hole/pi-hole Apr 18, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@yubiuser
Copy link
Member

See the description in the linked PR for why this is a bug

@thebeanieman
Copy link
Author

This is being worked on and seems very close to being resolved:
#1911

I don't use github much, so sorry if I have made any mistakes.

@yubiuser
Copy link
Member

Will be fixed by 8cad811

@yubiuser yubiuser linked a pull request Feb 20, 2022 that will close this issue
8 tasks
@lionralfs
Copy link
Contributor

As this is fixed in #2130, I guess #1911 is obsolete and can be closed right?

@yubiuser
Copy link
Member

@thebeanieman
Copy link
Author

Hello,

This is not fixed. Exactly the same error happens with Web Interface [v5.12].

Thanks,
David

@PromoFaux
Copy link
Member

Confirmed -

privacy

@thebeanieman
Copy link
Author

Hey @PromoFaux,

Thank you for re-opening the issue and included a video showing the issue.

Thanks,
David

@yubiuser
Copy link
Member

The issue was fixed by 8cad811, however, re-introduced by #2126.

#2183 should fix this now.

Please try it with

pihole checkout web reload/privacy

You can go back on track with pihole checkout master anytime (and before you want to upgrade to the next Pi-hole version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants