Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rate-limiting options from settings page #2130

Merged
merged 6 commits into from
Feb 26, 2022
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 19, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Make it easier to configure rate-limiting by offerings a GUI setting.

How does this PR accomplish the above?:

Add the following section to Settings -> DNS -> Advanced DNS settings

Screenshot from 2022-02-19 11-00-52

Depends on pi-hole/pi-hole#4621

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
…ld config data from before running the savesettings.php code

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team February 19, 2022 10:01
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of the input fields look a bit off. Can you make them a bit shorter
Bildschirmfoto zu 2022-02-19 21-36-52

settings.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
scripts/pi-hole/php/FTL.php Show resolved Hide resolved
Co-authored-by: yubiuser <ckoenig@posteo.de>
@yubiuser yubiuser linked an issue Feb 20, 2022 that may be closed by this pull request
Signed-off-by: DL6ER <dl6er@dl6er.de>
settings.php Outdated Show resolved Hide resolved
Co-authored-by: yubiuser <ckoenig@posteo.de>
@DL6ER DL6ER requested review from yubiuser and a team February 26, 2022 15:34
@yubiuser yubiuser merged commit 44103b9 into devel Feb 26, 2022
@yubiuser yubiuser deleted the new/set_rate_limit branch February 26, 2022 16:05
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings > Privacy does not show updated as expected
4 participants