-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to delete multiple warnings at once #2133
Conversation
de1ee1a
to
6db37c1
Compare
Something isn't right about the messages when mass-deleting: The blue boxes never turn to green. The deletion still worked for all selected messages. It would be cleaner if there is only one popup saying that PS: Purely cosmetic but maybe we should disable the buttons when there are no issues in the table: Also I'm wondering about the position of these buttons. Mostly thinking about mobile displays that will not show the entire page at once: should they be at the bottom of the table? You typically scroll down on a page when doing the selections. Or we might want to have them both at the top and the bottom. |
More thoughts about usability:
|
7b5d65f
to
fb44f22
Compare
- add Datatables extension Select (CSS and js); - add Datatables extension Buttons (CSS and js); - allow selection of multiple warnings; - new button to select all; - new button to delete all selected warnings; - add icons for the buttons; - hide buttons if all messages were deleted; - update CSS themes to format the new items; - Fix: update icon count after warning deletion; - Fix: remove triangle icon after delete last warning; Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
8da1955
to
6288112
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7eebe72
to
7fb78c5
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
7fb78c5
to
bc2647e
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
|
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Feature request: port this to all other tables 😁 |
We receive a high number of requests, but as a free open-source project run by volunteers we have very limited resources. Thank you for your understanding. 🤣 🤣 🤣 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/one-click-delete-mark-as-read-all-warnings/53097/7 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
This PR adds new controls to the messages table to allow selection and deletion of multiple warnings at once.
How does this PR accomplish the above?:
This PR adds Datatables extensions, buttons and CSS.
Fix: update icon count after delete a warning. Also remove the triangle icon after delete last warning.
What documentation changes (if any) are needed to support this PR?:
none.