Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show debug logs in colors #2142

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Show debug logs in colors #2142

merged 2 commits into from
Mar 12, 2022

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Mar 12, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Debug logs are colorful when generated via command line, but don't display colors in the web interface.
This PR shows debug logs in colors.

How does this PR accomplish the above?:

Replaces the ANSI color codes by HTML tags and CSS.

Note:
needs pi-hole/pi-hole#4645 to work.

What documentation changes (if any) are needed to support this PR?:

none

- Add function and CSS to show colorful debug log
- Adjusts to #output element

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@PromoFaux PromoFaux merged commit d6323d5 into devel Mar 12, 2022
@PromoFaux PromoFaux deleted the color_debug_output branch March 12, 2022 18:02
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/enhancement-visibility-of-debug-token-in-web-gui/32051/25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants