-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show debug logs in colors #2142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
- Add function and CSS to show colorful debug log - Adjusts to #output element Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
color_debug_output
branch
from
March 12, 2022 06:25
8087961
to
ea24655
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
PromoFaux
approved these changes
Mar 12, 2022
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This was referenced Apr 20, 2022
1 task
1 task
This was referenced Apr 24, 2022
This was referenced Apr 26, 2022
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/enhancement-visibility-of-debug-token-in-web-gui/32051/25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Debug logs are colorful when generated via command line, but don't display colors in the web interface.
This PR shows debug logs in colors.
How does this PR accomplish the above?:
Replaces the ANSI color codes by HTML tags and CSS.
Note:
needs pi-hole/pi-hole#4645 to work.
What documentation changes (if any) are needed to support this PR?:
none